-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device_info_app_build_configuration property to all events #182
Conversation
@Automattic/platform-9 I could use some help testing this in configurations other than Debug. I'm not even sure if we can test the TestFlight one without actually pushing a new update, so maybe something to watch out for in the next release cycle |
Maybe we should setup distribution for the Tracks-Demo app that's part of the project via App Center? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the testing instructions and I can see device_info_app_build_configuration
in properties.
I tested only with the WCiOS app though. I think it would not hurt to test with WPiOS as well, sometime net week perhaps?
It is not integrated on WPiOS yet, but I'll give it a try next week |
50d8c55
to
7b4abbc
Compare
Thanks again for doing this, @koke! |
Adds a new
device_info_app_build_configuration
property to all events that can be:Release-alpha
builds, I believe we use this for Installable Builds on PRs. This requires the app integrating the library to define anALPHA
preprocessor macro.Release
builds uploaded to TestFlightRelease
builds uploaded to the App StoreAlpha releases can be configured with the following in the app's
Podfile
:I've only implemented this for Woo in woocommerce/woocommerce-ios#4468, so I'm not sure if integrating this in WordPress will require any changes for the WP Internal builds.
Part of woocommerce/woocommerce-ios#4432
To test
- [TracksServiceRemote sendBatchOfEvents:withSharedProperties:completionHandler:]
and ensure that theproperties
argument containsDebug
fordevice_info_app_build_configuration
.I haven't been able to test anything other than Debug builds yet 😞